linux-kernel - Re: [PATCH v2 0/2] char: tpm: add new driver for tpm i2c ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190715094541.zjqxainggjuvjxd2@linux.intel.com>
Date:   Mon, 15 Jul 2019 12:45:41 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Tomer Maimon <tmaimon77@...il.com>
Cc:     Oshri Alkobi <oshrialkoby85@...il.com>,
        Alexander Steffen <Alexander.Steffen@...ineon.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, peterhuewe@....de,
        jgg@...pe.ca, Arnd Bergmann <arnd@...db.de>,
        Greg KH <gregkh@...uxfoundation.org>,
        IS20 Oshri Alkoby <oshri.alkoby@...oton.com>,
        devicetree <devicetree@...r.kernel.org>,
        AP MS30 Linux Kernel community 
        <linux-kernel@...r.kernel.org>, linux-integrity@...r.kernel.org,
        gcwilson@...ibm.com, kgoldman@...ibm.com, nayna@...ux.vnet.ibm.com,
        IS30 Dan Morav <Dan.Morav@...oton.com>,
        eyal.cohen@...oton.com
Subject: Re: [PATCH v2 0/2] char: tpm: add new driver for tpm i2c ptp

On Mon, Jul 15, 2019 at 11:08:47AM +0300, Tomer Maimon wrote:
>    Thanks for your feedback and sorry for the late response.
>
>    Due to the amount of work required to handle this technical feedback and
>    project constraints we need to put this task on hold for the near future.
>
>    In the meantime, anyone from the community is welcome to take over this
>    code and handle the re-design for the benefit of the entire TPM community.

Ok, so there is already driver for this called tpm_tis_core.

So you go and create a new module, whose name given the framework of
things that we already have deployed, is destined to be tpm_tis_i2c.

Then you roughly implement a new physical layer by using  a callback
interface provided to you by tpm_tis_core.

The so called re-design was already addressed by Alexander [1].

How hard can it be seriously?

[1] https://lkml.org/lkml/2019/7/4/331

/Jarkko