linux-kernel - Re: [PATCH] sched/fair: fix coccinelle warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190715095147.GZ3419@hirez.programming.kicks-ass.net>
Date:   Mon, 15 Jul 2019 11:51:47 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Yi Wang <wang.yi59@....com.cn>
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org,
        xue.zhihong@....com.cn, up2wing@...il.com, wang.liang82@....com.cn
Subject: Re: [PATCH] sched/fair: fix coccinelle warnings

On Mon, Jul 15, 2019 at 10:45:26AM +0800, Yi Wang wrote:
> This fixes the following coccinelle warning:
> ./kernel/sched/fair.c:8688:9-10: WARNING: return of 0/1 in function 'voluntary_active_balance' with return type bool
> 
> Return type bool instead of 0/1.

I don't much appreciate these patches. I think 0/1 are perfectly fine
return values for a boolean function.