linux-kernel - Re: [PATCH BUGFIX IMPROVEMENT 1/1] block, bfq: check also in-flight I/O in dispatch plugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <B064EF63-B7F6-4BA3-BA0A-FF9579893971@linaro.org>
Date:   Mon, 15 Jul 2019 12:53:38 +0200
From:   Paolo Valente <paolo.valente@...aro.org>
To:     Holger Hoffstätte <holger@...lied-asynchrony.com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        linux-block <linux-block@...r.kernel.org>,
        kernel list <linux-kernel@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>, linus.walleij@...aro.org,
        bfq-iosched@...glegroups.com, oleksandr@...alenko.name
Subject: Re: [PATCH BUGFIX IMPROVEMENT 1/1] block, bfq: check also in-flight
 I/O in dispatch plugging

Ops, my fault of course. I submitted the patch I made on top of the dev version of bfq. Preparing a V2. Sorry.

> Il giorno 15 lug 2019, alle ore 12:49, Holger Hoffstätte <holger@...lied-asynchrony.com> ha scritto:
> 
> On 7/15/19 12:18 PM, Paolo Valente wrote:
>> Didn't I simply move it forward in that commit?
>>> Il giorno 15 lug 2019, alle ore 12:16, Holger Hoffstätte <holger@...lied-asynchrony.com> ha scritto:
>>> Paolo,
>>> 
>>> The function idling_needed_for_service_guarantees() was just removed in 5.3-commit
>>> 3726112ec731 ("block, bfq: re-schedule empty queues if they deserve I/O plugging").
> 
> Argh, sorry - yes you did, it failed to apply because the asymmetric_scenario
> variable was already gone. Fixing the patch to just return the expression so that
> it matches 3726112ec731 worked.
> 
> All good!
> Holger