linux-kernel - Re: [PATCH] kvm: vmx: fix coccinelle warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a29ec5f9-2f35-5d85-a321-002315591c66@redhat.com>
Date:   Mon, 15 Jul 2019 13:55:45 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Yi Wang <wang.yi59@....com.cn>
Cc:     rkrcmar@...hat.com, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, hpa@...or.com, x86@...nel.org, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, xue.zhihong@....com.cn,
        up2wing@...il.com, wang.liang82@....com.cn
Subject: Re: [PATCH] kvm: vmx: fix coccinelle warnings

On 15/07/19 06:35, Yi Wang wrote:
> This fixes the following coccinelle warning:
> 
> WARNING: return of 0/1 in function 'vmx_need_emulation_on_page_fault'
> with return type bool
> 
> Return false instead of 0.
> 
> Signed-off-by: Yi Wang <wang.yi59@....com.cn>
> ---
>  arch/x86/kvm/vmx/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index d98eac3..8b5f352 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7418,7 +7418,7 @@ static int enable_smi_window(struct kvm_vcpu *vcpu)
>  
>  static bool vmx_need_emulation_on_page_fault(struct kvm_vcpu *vcpu)
>  {
> -	return 0;
> +	return false;
>  }
>  
>  static __init int hardware_setup(void)
> 

Queued, thanks.

Paolo