linux-kernel - Re: [PATCH v3] tpm: tpm_ibm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190716195238.79271980@kitsune.suse.cz>
Date:   Tue, 16 Jul 2019 19:52:38 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     Nayna Jain <nayna@...ux.ibm.com>,
        Sachin Sant <sachinp@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org, Mimi Zohar <zohar@...ux.ibm.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        linux-integrity@...r.kernel.org,
        George Wilson <gcwilson@...ux.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org, Peter Huewe <peterhuewe@....de>
Subject: Re: [PATCH v3] tpm: tpm_ibm_vtpm: Fix unallocated banks

On Fri, 12 Jul 2019 00:13:57 +0300
Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> wrote:

> On Thu, Jul 11, 2019 at 11:28:24PM +0300, Jarkko Sakkinen wrote:
> > On Thu, Jul 11, 2019 at 12:13:35PM -0400, Nayna Jain wrote:  
> > > The nr_allocated_banks and allocated banks are initialized as part of
> > > tpm_chip_register. Currently, this is done as part of auto startup
> > > function. However, some drivers, like the ibm vtpm driver, do not run
> > > auto startup during initialization. This results in uninitialized memory
> > > issue and causes a kernel panic during boot.
> > > 
> > > This patch moves the pcr allocation outside the auto startup function
> > > into tpm_chip_register. This ensures that allocated banks are initialized
> > > in any case.
> > > 
> > > Fixes: 879b589210a9 ("tpm: retrieve digest size of unknown algorithms with
> > > PCR read")
> > > Reported-by: Michal Suchanek <msuchanek@...e.de>
> > > Signed-off-by: Nayna Jain <nayna@...ux.ibm.com>
> > > Reviewed-by: Mimi Zohar <zohar@...ux.ibm.com>
> > > Tested-by: Sachin Sant <sachinp@...ux.vnet.ibm.com>
> > > Tested-by: Michal Suchánek <msuchanek@...e.de>  
> > 
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>  
> 
> Thanks a lot! It is applied now.

Fixes the issue for me.

Thanks

Michal