linux-kernel - Re: [PATCH 5/6] leds: apu: fix error on probing failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190716192805.GE10400@amd>
Date:   Tue, 16 Jul 2019 21:28:05 +0200
From:   Pavel Machek <pavel@....cz>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     linux-kernel@...r.kernel.org, jacek.anaszewski@...il.com,
        dmurphy@...com, linux-leds@...r.kernel.org
Subject: Re: [PATCH 5/6] leds: apu: fix error on probing failure

On Mon 2019-07-15 16:57:32, Enrico Weigelt, metux IT consult wrote:
> From: Enrico Weigelt <info@...ux.net>
> 
> The current error message on failed probing tends to be a bit
> misleading. Fix it to tell exactly that an APU v1 was not found.
> 
> Signed-off-by: Enrico Weigelt <info@...ux.net>
> ---
>  drivers/leds/leds-apu.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/leds/leds-apu.c b/drivers/leds/leds-apu.c
> index 451cb9f..892fea7 100644
> --- a/drivers/leds/leds-apu.c
> +++ b/drivers/leds/leds-apu.c
> @@ -170,13 +170,9 @@ static int __init apu_led_init(void)
>  	struct platform_device *pdev;
>  	int err;
>  
> -	if (!dmi_match(DMI_SYS_VENDOR, "PC Engines")) {
> -		pr_err("No PC Engines board detected\n");
> -		return -ENODEV;
> -	}
> -	if (!(dmi_match(DMI_PRODUCT_NAME, "APU"))) {
> -		pr_err("Unknown PC Engines board: %s\n",
> -				dmi_get_system_info(DMI_PRODUCT_NAME));
> +	if (!(dmi_match(DMI_SYS_VENDOR, "PC Engines") &&
> +	      dmi_match(DMI_PRODUCT_NAME, "APU"))) {
> +		pr_err("No PC Engines APUv1 board detected\n");

You may want to add here: "For APUv2,3 support, enable CONFIG_xxx".

If you have any APUv2 users (and you may), this si chance to get their
attention.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)