linux-kernel - Re: [PATCH v1 3/3] clk: qcom: rcg: update the DFS macro for RCG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <243de3a4-292b-77c0-6232-0b38d124d183@codeaurora.org>
Date:   Tue, 16 Jul 2019 09:52:02 +0530
From:   Taniya Das <tdas@...eaurora.org>
To:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/3] clk: qcom: rcg: update the DFS macro for RCG

Hello Stephen,

Thanks for the review.

On 7/16/2019 4:14 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2019-05-12 20:44:46)
>> On 5/10/2019 11:24 PM, Stephen Boyd wrote:
>>>>>> diff --git a/drivers/clk/qcom/clk-rcg.h b/drivers/clk/qcom/clk-rcg.h
>>>>>> index 5562f38..e40e8f8 100644
>>>>>> --- a/drivers/clk/qcom/clk-rcg.h
>>>>>> +++ b/drivers/clk/qcom/clk-rcg.h
>>>>>> @@ -171,7 +171,7 @@ struct clk_rcg_dfs_data {
>>>>>>     };
>>>>>>
>>>>>>     #define DEFINE_RCG_DFS(r) \
>>>>>> -       { .rcg = &r##_src, .init = &r##_init }
>>>>>> +       { .rcg = &r, .init = &r##_init }
>>>>>
>>>>> Why do we need to rename the init data?
>>>>>
>>>>
>>>> We want to manage the init data as the clock source name, so that we
>>>> could manage to auto generate our code. So that we do not have to
>>>> re-name the clock init data manually if the DFS source names gets
>>>> updated at any point of time.
>>>>
>>>
>>> Why is the clk name changing to not have a _src after the "root" of the
>>> clk name? As long as I can remember, RCGs have a "_src" postfix.
>>>
>>
>> Yes, the RCGs would have _src, so we do want the init data also to be
>> generated with _src postfix. So that we do not have to manually clean up
>> the generated code.
>>
> 
> Please manually cleanup the generated code, or fix the code
> generator to do what you want.
> 

Fixing the code manually is not what we intend to do and it is time 
consuming with too many DFS controlled clocks. This really helps us 
align to internal code.

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--