linux-kernel - Re: [PATCH v1 3/3] clk: qcom: rcg: update the DFS macro for RCG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190716232228.2B84F2173E@mail.kernel.org>
Date:   Tue, 16 Jul 2019 16:22:27 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Taniya Das <tdas@...eaurora.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/3] clk: qcom: rcg: update the DFS macro for RCG

Quoting Taniya Das (2019-07-15 21:22:02)
> Hello Stephen,
> 
> Thanks for the review.
> 
> On 7/16/2019 4:14 AM, Stephen Boyd wrote:
> > Quoting Taniya Das (2019-05-12 20:44:46)
> >> On 5/10/2019 11:24 PM, Stephen Boyd wrote:
> >>> Why is the clk name changing to not have a _src after the "root" of the
> >>> clk name? As long as I can remember, RCGs have a "_src" postfix.
> >>>
> >>
> >> Yes, the RCGs would have _src, so we do want the init data also to be
> >> generated with _src postfix. So that we do not have to manually clean up
> >> the generated code.
> >>
> > 
> > Please manually cleanup the generated code, or fix the code
> > generator to do what you want.
> > 
> 
> Fixing the code manually is not what we intend to do and it is time 
> consuming with too many DFS controlled clocks. This really helps us 
> align to internal code.
> 

And you can't fix the code generator to drop the _src part of whatever
is spit out for the DFS lines?