linux-kernel - [PATCH] arm64: Avoid pointless schedule_preempt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1907171036490.1767@nanos.tec.linutronix.de>
Date:   Wed, 17 Jul 2019 10:43:59 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     LAK <linux-arm-kernel@...ts.infradead.org>
cc:     LKML <linux-kernel@...r.kernel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: [PATCH] arm64: Avoid pointless schedule_preempt_irq() invocations

When preempt_count is zero on return from interrupt then
schedule_preempt_irq() is invoked even if TIF_NEED_RESCHED is not set.

That does not make sense because schedule_preempt_irq() has to go through a
full __schedule() for nothing in that case.

Check TIF_NEED_RESCHED and invoke schedule_preempt_irq() only if set.

Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
Found while staring at some RT wrecakge in that area.
---
 arch/arm64/kernel/entry.S |    4 ++++
 1 file changed, 4 insertions(+)

--- a/arch/arm64/kernel/entry.S
+++ b/arch/arm64/kernel/entry.S
@@ -680,6 +680,10 @@ alternative_if ARM64_HAS_IRQ_PRIO_MASKIN
 	orr	x24, x24, x0
 alternative_else_nop_endif
 	cbnz	x24, 1f				// preempt count != 0 || NMI return path
+
+	ldr	x0, [tsk, #TSK_TI_FLAGS]        // get flags
+	tbz	x0, #TIF_NEED_RESCHED, 1f      	// needs rescheduling?
+
 	bl	preempt_schedule_irq		// irq en/disable is done inside
 1:
 #endif