linux-kernel - RE: [EXT] Re: [v5,2/2] Documentation: dt: binding: rtc: add binding for ftm alarm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB7PR04MB44902483232D323AF611D6298FC90@DB7PR04MB4490.eurprd04.prod.outlook.com>
Date:   Wed, 17 Jul 2019 10:05:13 +0000
From:   Biwen Li <biwen.li@....com>
To:     Rob Herring <robh+dt@...nel.org>
CC:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Leo Li <leoyang.li@....com>,
        "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Xiaobo Xie <xiaobo.xie@....com>,
        Jiafei Pan <jiafei.pan@....com>, Ran Wang <ran.wang_1@....com>,
        Mark Rutland <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [EXT] Re: [v5,2/2] Documentation: dt: binding: rtc: add binding
 for ftm alarm driver

> 
> Caution: EXT Email
> 
> On Tue, Jul 16, 2019 at 4:26 AM Biwen Li <biwen.li@....com> wrote:
> >
> > The patch adds binding for ftm alarm driver
> 
> Bindings are for h/w, not drivers...
> 
> 'dt-bindings: rtc: ...' for the subject prefix.
I will correct it in v6.
> 
> >
> > Signed-off-by: Biwen Li <biwen.li@....com>
> > ---
> > Change in v5:
> >     - None
> >
> > Change in v4:
> >     - add note about dts and kernel options
> >     - add aliases in example
> >
> > Change in v3:
> >         - remove reg-names property
> >         - correct cells number
> >
> > Change in v2:
> >         - replace ls1043a with ls1088a as example
> >         - add rcpm node and fsl,rcpm-wakeup property
> >
> >
> >  .../bindings/rtc/rtc-fsl-ftm-alarm.txt        | 49 +++++++++++++++++++
> >  1 file changed, 49 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> > b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> > new file mode 100644
> > index 000000000000..fb018065406c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> > @@ -0,0 +1,49 @@
> > +Freescale FlexTimer Module (FTM) Alarm
> > +
> > +Note:
> > +- The driver depends on RCPM driver
> > +  to wake up system in sleep.
> > +- Need stop using RTC_HCTOSYS or use the DT aliases
> > +  to ensure the driver is not used as the primary RTC.
> > +  (Select DT aliases defaultly)
> 
> This is Linux specific and not relevant to the binding.
Ok, I will remove all of the Note in v6.
> 
> > +
> > +Required properties:
> > +- compatible : Should be "fsl,<chip>-ftm-alarm", the
> > +              supported chips include
> > +              "fsl,ls1012a-ftm-alarm"
> > +              "fsl,ls1021a-ftm-alarm"
> > +              "fsl,ls1028a-ftm-alarm"
> > +              "fsl,ls1043a-ftm-alarm"
> > +              "fsl,ls1046a-ftm-alarm"
> > +              "fsl,ls1088a-ftm-alarm"
> > +              "fsl,ls208xa-ftm-alarm"
> > +- reg : Specifies base physical address and size of the register sets
> > +for the
> > +  FlexTimer Module and base physical address of IP Powerdown
> > +Exception Control
> > +  Register.
> > +- interrupts : Should be the FlexTimer Module interrupt.
> > +- fsl,rcpm-wakeup property and rcpm node : Please refer
> > +       Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > +
> > +Optional properties:
> > +- big-endian: If the host controller is big-endian mode, specify this property.
> > +  The default endian mode is little-endian.
> > +
> > +Example:
> > +aliases {
> > +       ...
> > +       rtc1 = ftm_alarm0; /* Use flextimer alarm driver as /dev/rtc1 */
> > +       ...
> > +};
> 
> Drop the aliases part. It's not going to work when this is converted to DT schema
> and the comment is Linux specific.
Sorry,I can't drop the aliases part. If any user uses the alarm driver as rtc0,
the user will get wrong time from /dev/rtc0.It is very important.
> 
> > +
> > +rcpm: rcpm@...4040 {
> > +       compatible = "fsl,ls1088a-rcpm", "fsl,qoriq-rcpm-2.1+";
> > +       reg = <0x0 0x1e34040 0x0 0x18>;
> > +       fsl,#rcpm-wakeup-cells = <6>;
> 
> Before there are any users of this, either drop it if it is not variable or the correct
> form would be '#fsl,rcpm-wakeup-cells'.
I will replace 'fsl,#rcpm-wakeup-cells' with '#fsl,rcpm-wakeup-cells' in v6.
> 
> > +};
> > +
> > +ftm_alarm0: timer@...0000 {
> > +       compatible = "fsl,ls1088a-ftm-alarm";
> > +       reg = <0x0 0x2800000 0x0 0x10000>;
> > +       fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000 0x0>;
> > +       interrupts = <0 44 4>;
> > +};
> > --
> > 2.17.1
> >