[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1563417919.4276.0.camel@realtek.com>
Date: Thu, 18 Jul 2019 02:45:19 +0000
From: Pkshih <pkshih@...ltek.com>
To: "Larry.Finger@...inger.net" <Larry.Finger@...inger.net>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"yuehaibing@...wei.com" <yuehaibing@...wei.com>,
"kvalo@...eaurora.org" <kvalo@...eaurora.org>,
"natechancellor@...il.com" <natechancellor@...il.com>,
"hariprasad.kelam@...il.com" <hariprasad.kelam@...il.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"davem@...emloft.net" <davem@...emloft.net>,
"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] rtlwifi: btcoex: fix issue possible condition with no effect (if == else)
On Fri, 2019-07-12 at 19:15 +0000, Hariprasad Kelam wrote:
> fix below issue reported by coccicheck
> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:514:1-3:
> WARNING: possible condition with no effect (if == else)
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> index 152242a..191dafd0 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> @@ -509,13 +509,7 @@ static u32 halbtc_get_wifi_link_status(struct btc_coexist
> *btcoexist)
>
> static s32 halbtc_get_wifi_rssi(struct rtl_priv *rtlpriv)
> {
> - int undec_sm_pwdb = 0;
> -
> - if (rtlpriv->mac80211.link_state >= MAC80211_LINKED)
> - undec_sm_pwdb = rtlpriv->dm.undec_sm_pwdb;
> - else /* associated entry pwdb */
> - undec_sm_pwdb = rtlpriv->dm.undec_sm_pwdb;
> - return undec_sm_pwdb;
> + return rtlpriv->dm.undec_sm_pwdb;
> }
>
> static bool halbtc_get(void *void_btcoexist, u8 get_type, void *out_buf)
It looks good to me. Thank you.
Acked-by: Ping-Ke Shih <pkshih@...ltek.com>
Powered by blists - more mailing lists