linux-kernel - Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190718164550-mutt-send-email-mst@kernel.org>
Date:   Thu, 18 Jul 2019 16:46:28 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Wei Wang <wei.w.wang@...el.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        xdeguillard@...are.com, namit@...are.com, pagupta@...hat.com,
        riel@...riel.com, dave.hansen@...el.com, david@...hat.com,
        konrad.wilk@...cle.com, yang.zhang.wz@...il.com, nitesh@...hat.com,
        lcapitulino@...hat.com, aarcange@...hat.com, pbonzini@...hat.com,
        alexander.h.duyck@...ux.intel.com, dan.j.williams@...el.com
Subject: Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal

On Thu, Jul 18, 2019 at 04:42:50PM -0400, Michael S. Tsirkin wrote:
> On Thu, Jul 18, 2019 at 01:36:26PM -0700, Andrew Morton wrote:
> > On Thu, 18 Jul 2019 08:26:11 -0400 "Michael S. Tsirkin" <mst@...hat.com> wrote:
> > 
> > > On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote:
> > > > Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces)
> > > > 
> > > > A #GP is reported in the guest when requesting balloon inflation via
> > > > virtio-balloon. The reason is that the virtio-balloon driver has
> > > > removed the page from its internal page list (via balloon_page_pop),
> > > > but balloon_page_enqueue_one also calls "list_del"  to do the removal.
> > > > This is necessary when it's used from balloon_page_enqueue_list, but
> > > > not from balloon_page_enqueue_one.
> > > > 
> > > > So remove the list_del balloon_page_enqueue_one, and update some
> > > > comments as a reminder.
> > > > 
> > > > Signed-off-by: Wei Wang <wei.w.wang@...el.com>
> > > 
> > > 
> > > ok I posted v3 with typo fixes. 1/2 is this patch with comment changes. Pls take a look.
> > 
> > I really have no idea what you're talking about here :(.  Some other
> > discussion and patch thread, I suppose.
> > 
> > You're OK with this patch?
> 
> Not exactly. I will send v5 soon, you will be CC'd.

Just done. Do you see it?

> > Should this patch have cc:stable?
> 
> Yes. Sorry.

Actually no - 418a3ab1e778 is new since 5.2.