linux-kernel - Re: [PATCH] be2net: fix adapter->big_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190718.162928.124906203979938369.davem@davemloft.net>
Date:   Thu, 18 Jul 2019 16:29:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     cai@....pw
Cc:     morbo@...gle.com, ndesaulniers@...gle.com, jyknight@...gle.com,
        sathya.perla@...adcom.com, ajit.khaparde@...adcom.com,
        sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com,
        arnd@...db.de, dhowells@...hat.com, hpa@...or.com,
        netdev@...r.kernel.org, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org, natechancellor@...il.com
Subject: Re: [PATCH] be2net: fix adapter->big_page_size miscaculation

From: Qian Cai <cai@....pw>
Date: Thu, 18 Jul 2019 19:26:47 -0400

> 
> 
>> On Jul 18, 2019, at 5:21 PM, Bill Wendling <morbo@...gle.com> wrote:
>> 
>> [My previous response was marked as spam...]
>> 
>> Top-of-tree clang says that it's const:
>> 
>> $ gcc a.c -O2 && ./a.out
>> a is a const.
>> 
>> $ clang a.c -O2 && ./a.out
>> a is a const.
> 
> 
> I used clang-7.0.1. So, this is getting worse where both GCC and clang will start to suffer the
> same problem.

Then rewrite the module parameter macros such that the non-constness
is evident to all compilers regardless of version.

That is the place to fix this, otherwise we will just be adding hacks
all over the place rather than in just one spot.

Thanks.