linux-kernel - Re: [PATCH] net: bcmgenet: use promisc for unsupported filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f6422b5-e839-1600-6749-048a7e31ea96@gmail.com>
Date:   Wed, 17 Jul 2019 20:38:47 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     justinpopo6@...il.com, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, davem@...emloft.net,
        opendmb@...il.com
Subject: Re: [PATCH] net: bcmgenet: use promisc for unsupported filters



On 7/17/2019 2:58 PM, justinpopo6@...il.com wrote:
> From: Justin Chen <justinpopo6@...il.com>
> 
> Currently we silently ignore filters if we cannot meet the filter
> requirements. This will lead to the MAC dropping packets that are
> expected to pass. A better solution would be to set the NIC to promisc
> mode when the required filters cannot be met.
> 
> Also correct the number of MDF filters supported. It should be 17,
> not 16.
> 
> Signed-off-by: Justin Chen <justinpopo6@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Thanks Justin!
-- 
Florian