linux-kernel - Re: [patch v2] crypto: ccp - Fix SEV_VERSION_GREATER_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190718054151.fi5akslvzp7h5b2w@gondor.apana.org.au>
Date:   Thu, 18 Jul 2019 13:41:51 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     David Rientjes <rientjes@...gle.com>
Cc:     "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        Cfir Cohen <cfir@...gle.com>,
        "Natarajan, Janakarajan" <Janakarajan.Natarajan@....com>,
        "Hook, Gary" <Gary.Hook@....com>, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [patch v2] crypto: ccp - Fix SEV_VERSION_GREATER_OR_EQUAL

On Fri, Jul 12, 2019 at 01:41:58PM -0700, David Rientjes wrote:
> SEV_VERSION_GREATER_OR_EQUAL() will fail if upgrading from 2.2 to 3.1, for
> example, because the minor version is not equal to or greater than the
> major.
> 
> Fix this and move to a static inline function for appropriate type
> checking.
> 
> Fixes: edd303ff0e9e ("crypto: ccp - Add DOWNLOAD_FIRMWARE SEV command")
> Reported-by: Cfir Cohen <cfir@...gle.com>
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
>  v2: no need to check api_major >= maj after checking api_major > maj
>      per Thomas
> 
>  drivers/crypto/ccp/psp-dev.c | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt