linux-kernel - Re: [PATCH] acpi: blacklist: fix clang warning for unused dmi table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Jul 2019 10:43:24 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Len Brown <lenb@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] acpi: blacklist: fix clang warning for unused dmi table

On Wednesday, July 10, 2019 3:05:43 PM CEST Arnd Bergmann wrote:
> When CONFIG_DMI is disabled, we only have a tentative declaration,
> which causes a warning from clang:
> 
> drivers/acpi/blacklist.c:20:35: error: tentative array definition assumed to have one element [-Werror]
> static const struct dmi_system_id acpi_rev_dmi_table[] __initconst;
> 
> As the variable is not actually used here, hide it entirely
> in an #ifdef to shut up the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/acpi/blacklist.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index ad2c565f5cbe..a86a770c9b79 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -17,7 +17,9 @@
>  
>  #include "internal.h"
>  
> +#ifdef CONFIG_DMI
>  static const struct dmi_system_id acpi_rev_dmi_table[] __initconst;
> +#endif
>  
>  /*
>   * POLICY: If *anything* doesn't work, put it on the blacklist.
> @@ -61,7 +63,9 @@ int __init acpi_blacklisted(void)
>  	}
>  
>  	(void)early_acpi_osi_init();
> +#ifdef CONFIG_DMI
>  	dmi_check_system(acpi_rev_dmi_table);
> +#endif
>  
>  	return blacklisted;
>  }
> 

Applied, thanks!