linux-kernel - Re: [PATCH] dt-bindings: pinctrl: stm32: Fix missing 'clocks' property in examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <634fce00-182d-80b8-b435-0cbdae57913c@st.com>
Date:   Thu, 18 Jul 2019 18:21:48 +0200
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Rob Herring <robh@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        <linux-gpio@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH] dt-bindings: pinctrl: stm32: Fix missing 'clocks'
 property in examples

Hi Rob

On 7/16/19 11:56 PM, Rob Herring wrote:
> Now that examples are validated against the DT schema, an error with
> required 'clocks' property missing is exposed:
> 
> Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \
> pinctrl@...20000: gpio@0: 'clocks' is a required property
> Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \
> pinctrl@...20000: gpio@...0: 'clocks' is a required property
> Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \
> pinctrl@...20000: gpio@...0: 'clocks' is a required property
> 
> Add the missing 'clocks' properties to the examples to fix the errors.
> 
> Fixes: 2c9239c125f0 ("dt-bindings: pinctrl: Convert stm32 pinctrl bindings to json-schema")
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>
> Cc: Alexandre Torgue <alexandre.torgue@...com>
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-stm32@...md-mailman.stormreply.com
> Signed-off-by: Rob Herring <robh@...nel.org>

Acked-by: Alexandre TORGUE <alexandre.torgue@...com>

Thanks
Alex


> ---
>   .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml         | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> index 3ac5d2088e49..91d3e78b3395 100644
> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> @@ -197,6 +197,7 @@ required:
>   examples:
>     - |
>       #include <dt-bindings/pinctrl/stm32-pinfunc.h>
> +    #include <dt-bindings/mfd/stm32f4-rcc.h>
>       //Example 1
>         pinctrl@...20000 {
>                 #address-cells = <1>;
> @@ -210,6 +211,7 @@ examples:
>                         #gpio-cells = <2>;
>                         reg = <0x0 0x400>;
>                         resets = <&reset_ahb1 0>;
> +                      clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOA)>;
>                         st,bank-name = "GPIOA";
>                 };
>          };
> @@ -227,6 +229,7 @@ examples:
>                         #gpio-cells = <2>;
>                         reg = <0x1000 0x400>;
>                         resets = <&reset_ahb1 0>;
> +                      clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOB)>;
>                         st,bank-name = "GPIOB";
>                         gpio-ranges = <&pinctrl 0 0 16>;
>                 };
> @@ -236,6 +239,7 @@ examples:
>                         #gpio-cells = <2>;
>                         reg = <0x2000 0x400>;
>                         resets = <&reset_ahb1 0>;
> +                      clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOC)>;
>                         st,bank-name = "GPIOC";
>                         ngpios = <5>;
>                         gpio-ranges = <&pinctrl 0 16 3>,
>