linux-kernel - Re: [PATCH v2 12/14] crypto: caam - execute module exit point only if necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB348569A551EE8B9AA99FF2D898CB0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
Date:   Fri, 19 Jul 2019 16:02:43 +0000
From:   Horia Geanta <horia.geanta@....com>
To:     Iuliana Prodan <iuliana.prodan@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@....com>
CC:     "David S. Miller" <davem@...emloft.net>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH v2 12/14] crypto: caam - execute module exit point only if
 necessary

On 7/19/2019 2:58 AM, Iuliana Prodan wrote:
> Commit 1b46c90c8e00 ("crypto: caam - convert top level drivers to libraries")
> changed entry and exit points behavior for caamalg,
> caamalg_qi, caamalg_qi2, caamhash, caampkc, caamrng.
> 
> For example, previously caam_pkc_init() and caam_pkc_exit() were
> module entry/exit points. This means that if an error would happen
> in caam_pkc_init(), then caam_pkc_exit() wouldn't have been called.
> After the mentioned commit, caam_pkc_init() and caam_pkc_exit()
> are manually called - from jr.c. caam_pkc_exit() is called
> unconditionally, even if caam_pkc_init() failed.
> 
> Added a global variable to keep the status of the algorithm
> registration and free of resources.
> The exit point of caampkc/caamrng module is executed only if the
> registration was successful. Therefore we avoid double free of
> resources in case the algorithm registration failed.
> 
> Fixes: 1b46c90c8e00 ("crypto: caam - convert top level drivers to libraries")
> Signed-off-by: Iuliana Prodan <iuliana.prodan@....com>
Reviewed-by: Horia Geantă <horia.geanta@....com>

Horia