linux-kernel - Re: [PATCH -next] drm/i915/dsi: remove set but not used variable 'hfront

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190719172335.GT5942@intel.com>
Date:   Fri, 19 Jul 2019 20:23:35 +0300
From:   Ville Syrjälä <ville.syrjala@...ux.intel.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
        rodrigo.vivi@...el.com, airlied@...ux.ie, daniel@...ll.ch,
        imre.deak@...el.com, madhav.chauhan@...el.com,
        vandita.kulkarni@...el.com, chris@...is-wilson.co.uk,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] drm/i915/dsi: remove set but not used variable
 'hfront_porch'

On Fri, Jul 19, 2019 at 01:51:36AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/gpu/drm/i915/display/icl_dsi.c: In function 'gen11_dsi_set_transcoder_timings':
> drivers/gpu/drm/i915/display/icl_dsi.c:768:6: warning:
>  variable 'hfront_porch' set but not used [-Wunused-but-set-variable]
> 
> It is never used and can be removed.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Thanks. Applied to drm-intel-next-queued.

> ---
>  drivers/gpu/drm/i915/display/icl_dsi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index 4d952accfaaa..a42348be0438 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -763,7 +763,7 @@ gen11_dsi_set_transcoder_timings(struct intel_encoder *encoder,
>  	enum transcoder dsi_trans;
>  	/* horizontal timings */
>  	u16 htotal, hactive, hsync_start, hsync_end, hsync_size;
> -	u16 hfront_porch, hback_porch;
> +	u16 hback_porch;
>  	/* vertical timings */
>  	u16 vtotal, vactive, vsync_start, vsync_end, vsync_shift;
>  
> @@ -772,8 +772,6 @@ gen11_dsi_set_transcoder_timings(struct intel_encoder *encoder,
>  	hsync_start = adjusted_mode->crtc_hsync_start;
>  	hsync_end = adjusted_mode->crtc_hsync_end;
>  	hsync_size  = hsync_end - hsync_start;
> -	hfront_porch = (adjusted_mode->crtc_hsync_start -
> -			adjusted_mode->crtc_hdisplay);
>  	hback_porch = (adjusted_mode->crtc_htotal -
>  		       adjusted_mode->crtc_hsync_end);
>  	vactive = adjusted_mode->crtc_vdisplay;
> 
> 

-- 
Ville Syrjälä
Intel