linux-kernel - Re: linux-next: Tree for Jul 18 (header build error)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190719103605.5ee9198a@canb.auug.org.au>
Date:   Fri, 19 Jul 2019 10:36:05 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kbuild <linux-kbuild@...r.kernel.org>,
        "Darrick J. Wong" <darrick.wong@...cle.com>
Subject: Re: linux-next: Tree for Jul 18 (header build error)

Hi all,

On Fri, 19 Jul 2019 10:05:57 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> On Thu, 18 Jul 2019 10:00:22 -0700 Randy Dunlap <rdunlap@...radead.org> wrote:
> >
> > on x86_64, when CONFIG_BLOCK is not set:
> > 
> >   CC      include/linux/iomap.h.s
> > In file included from <command-line>:0:0:
> > ./../include/linux/iomap.h: In function ‘iomap_sector’:
> > ./../include/linux/iomap.h:76:48: error: ‘SECTOR_SHIFT’ undeclared (first use in this function); did you mean ‘SECTIONS_SHIFT’?
> >   return (iomap->addr + pos - iomap->offset) >> SECTOR_SHIFT;
> >                                                 ^~~~~~~~~~~~  
> 
> include/linux/iomap.h should only be used when CONFIG_BLOCK is set (if
> you follow the Kconfig trail).  So maybe this header should only be
> compile tested if CONFIG_BLOCK is set.

Or maybe fs/iomap/ needs to grow a private header file for stuff like
iomap_sector() ?

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped