linux-kernel - Re: [PATCH] mm/Kconfig: additional help text for HMM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8428df79-94cc-cd17-1a48-c0e4b2202020@nvidia.com>
Date:   Thu, 18 Jul 2019 22:15:46 -0700
From:   John Hubbard <jhubbard@...dia.com>
To:     Ira Weiny <ira.weiny@...el.com>, <john.hubbard@...il.com>
CC:     <pavel@....cz>, <SCheung@...dia.com>, <akpm@...ux-foundation.org>,
        <aneesh.kumar@...ux.vnet.ibm.com>, <benh@...nel.crashing.org>,
        <bsingharora@...il.com>, <dan.j.williams@...el.com>,
        <dnellans@...dia.com>, <ebaskakov@...dia.com>,
        <hannes@...xchg.org>, <jglisse@...hat.com>,
        <kirill.shutemov@...ux.intel.com>, <linux-kernel@...r.kernel.org>,
        <liubo95@...wei.com>, <mhairgrove@...dia.com>, <mhocko@...nel.org>,
        <paulmck@...ux.vnet.ibm.com>, <ross.zwisler@...ux.intel.com>,
        <sgutti@...dia.com>, <torvalds@...ux-foundation.org>,
        <vdavydov.dev@...il.com>, Jason Gunthorpe <jgg@...pe.ca>,
        Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

On 7/18/19 9:34 PM, Ira Weiny wrote:
> On Thu, Jul 18, 2019 at 06:32:53PM -0700, john.hubbard@...il.com wrote:
>> From: John Hubbard <jhubbard@...dia.com>
...
>> +	  Select HMM_MIRROR if you have hardware that meets the above
>> +	  description. An early, partial list of such hardware is:
>> +	  an NVIDIA GPU >= Pascal, Mellanox IB >= mlx5, or an AMD GPU.
> 
> I don't think we want to put device information here.  If we want that
> information in Kconfig best to put it in the devices themselves.  Otherwise
> this list will get stale.
> 
> Other than that, looks good.
> 
> Reviewed-by: Ira Weiny <ira.weiny@...el.com>
> 

Hi Ira, thanks for the review, I'll remove that last sentence. I'll post a v2
with your reviewed by tag, in a new email thread. But first I'll wait to see 
if there are other replies.

thanks,
-- 
John Hubbard
NVIDIA