[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190719120432.GC11224@amd>
Date: Fri, 19 Jul 2019 14:04:33 +0200
From: Pavel Machek <pavel@....cz>
To: Christoph Hellwig <hch@...radead.org>
Cc: Jason Gunthorpe <jgg@...pe.ca>, john.hubbard@...il.com,
SCheung@...dia.com, akpm@...ux-foundation.org,
aneesh.kumar@...ux.vnet.ibm.com, benh@...nel.crashing.org,
bsingharora@...il.com, dan.j.williams@...el.com,
dnellans@...dia.com, ebaskakov@...dia.com, hannes@...xchg.org,
jglisse@...hat.com, jhubbard@...dia.com,
kirill.shutemov@...ux.intel.com, linux-kernel@...r.kernel.org,
liubo95@...wei.com, mhairgrove@...dia.com, mhocko@...nel.org,
paulmck@...ux.vnet.ibm.com, ross.zwisler@...ux.intel.com,
sgutti@...dia.com, torvalds@...ux-foundation.org,
vdavydov.dev@...il.com
Subject: Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option
On Fri 2019-07-19 05:00:43, Christoph Hellwig wrote:
> On Fri, Jul 19, 2019 at 08:48:53AM -0300, Jason Gunthorpe wrote:
> > It is like MMU_NOTIFIERS, if something needs it, then it will select
> > it.
> >
> > Maybe it should just be a hidden kconfig anyhow as there is no reason
> > to turn it on without also turning on a using driver.
>
> We can't just select it due to the odd X86_64 || PPC64 dependency.
>
> Which also answers Pavels question: you never really need it, as we
> can only use it for optional functionality due to that.
Okay, just explain it in the help text :-)..
Alternatively... you can have WANT_HMM_MIRROR option drivers select,
and option HMM_MIRROR which is yes if WANT_HMM_MIRROR && (X86_64 ||
PPC64), no?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)
Powered by blists - more mailing lists