linux-kernel - Re: [PATCH -next] drm/i915/icl: Remove set but not used variable 'src

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 Jul 2019 15:39:52 +0300
From:   Ville Syrjälä <ville.syrjala@...ux.intel.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
        rodrigo.vivi@...el.com, airlied@...ux.ie, daniel@...ll.ch,
        maarten.lankhorst@...ux.intel.com, matthew.d.roper@...el.com,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] drm/i915/icl: Remove set but not used variable
 'src_y'

On Fri, Jul 19, 2019 at 02:41:00AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/gpu/drm/i915/display/intel_sprite.c: In function 'g4x_sprite_check_scaling':
> drivers/gpu/drm/i915/display/intel_sprite.c:1494:13: warning:
>  variable 'src_y' set but not used [-Wunused-but-set-variable]
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Thanks. Applied to drm-intel-next-queued.

PS. I removed the "/icl" from the subject line because this has nothing
to do with icelake hardware.

> ---
>  drivers/gpu/drm/i915/display/intel_sprite.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> index 34586f29be60..9c3367491f04 100644
> --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> @@ -1491,7 +1491,7 @@ g4x_sprite_check_scaling(struct intel_crtc_state *crtc_state,
>  	const struct drm_framebuffer *fb = plane_state->base.fb;
>  	const struct drm_rect *src = &plane_state->base.src;
>  	const struct drm_rect *dst = &plane_state->base.dst;
> -	int src_x, src_y, src_w, src_h, crtc_w, crtc_h;
> +	int src_x, src_w, src_h, crtc_w, crtc_h;
>  	const struct drm_display_mode *adjusted_mode =
>  		&crtc_state->base.adjusted_mode;
>  	unsigned int cpp = fb->format->cpp[0];
> @@ -1502,7 +1502,6 @@ g4x_sprite_check_scaling(struct intel_crtc_state *crtc_state,
>  	crtc_h = drm_rect_height(dst);
>  
>  	src_x = src->x1 >> 16;
> -	src_y = src->y1 >> 16;
>  	src_w = drm_rect_width(src) >> 16;
>  	src_h = drm_rect_height(src) >> 16;
> 
> 

-- 
Ville Syrjälä
Intel