linux-kernel - Re: [PATCH 2/2] checkpatch: Improve SPDX license checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 20 Jul 2019 13:17:19 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Joe Perches <joe@...ches.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Andy Whitcroft <apw@...onical.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] checkpatch: Improve SPDX license checking

Hi Joe,

On Fri, 19 Jul 2019 20:09:19 -0700 Joe Perches <joe@...ches.com> wrote:
>
> On Sat, 2019-07-20 at 12:22 +1000, Stephen Rothwell wrote:
> > Hi Joe,
> > 
> > On Fri, 19 Jul 2019 15:31:33 -0700 Joe Perches <joe@...ches.com> wrote:  
> > > Use perl's m@<match>@ match and not /<match>/ comparisons to avoid
> > > an error using c90's // comment style.
> > > 
> > > Miscellanea:
> > > 
> > > o Use normal tab indentation and alignment
> > > 
> > > Link: http://lkml.kernel.org/r/5e4a8fa7901148fbcd77ab391e6dd0e6bf95777f.camel@perches.com
> > > 
> > > Signed-off-by: Joe Perches <joe@...ches.com>
> > > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> > > Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>  
> > 
> > Again, don't include other's (non author's) SOB lines.  
> 
> Nope.
> You _already_ signed-off this patch.
> I'm simply reproducing it.

My SOB line is *only* there because I am publishing that patch in
linux-next.  When Andrew sends that patch to Linus, my SOB should not
be there (since I will no longer be in the handling path).  My SOB does
not say anything about the correctness or otherwise of the patch.

Equally, if you sent that patch to Linus, Andrew's SOB should
(probably) not be there.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped