linux-kernel - Re: [PATCH] hwmon: (pmbus/max31785) Remove a useless #define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 21 Jul 2019 08:05:08 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus/max31785) Remove a useless #define

On Sun, Jul 21, 2019 at 12:15:53PM +0200, Christophe JAILLET wrote:
> There is a typo in MAX37185_NUM_FAN_PAGES. To be consistent, it should be
> MAX31785_NUM_FAN_PAGES (1 and 7 switched).
> 
> At line 24, we already have:
>    #define MAX31785_NR_FAN_PAGES		6
> and MAX37185_NUM_FAN_PAGES seems to be unused.
> 
> It is likely that it is only a typo and/or a left-over.
> So, axe it.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/pmbus/max31785.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/hwmon/pmbus/max31785.c b/drivers/hwmon/pmbus/max31785.c
> index 69d9029ea410..254b0f98c755 100644
> --- a/drivers/hwmon/pmbus/max31785.c
> +++ b/drivers/hwmon/pmbus/max31785.c
> @@ -244,8 +244,6 @@ static int max31785_write_word_data(struct i2c_client *client, int page,
>  #define MAX31785_VOUT_FUNCS \
>  	(PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT)
>  
> -#define MAX37185_NUM_FAN_PAGES 6
> -
>  static const struct pmbus_driver_info max31785_info = {
>  	.pages = MAX31785_NR_PAGES,
>