linux-kernel - Re: [PATCH v2] iommu/amd: fix a crash in iova_magazine_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgwd9vT1h7jKMU_E4ae2QLFFH69UxcXpO3J9YqEApdUNg@mail.gmail.com>
Date:   Sun, 21 Jul 2019 09:58:04 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Qian Cai <cai@....pw>
Cc:     Joerg Roedel <jroedel@...e.de>, Christoph Hellwig <hch@....de>,
        iommu <iommu@...ts.linux-foundation.org>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] iommu/amd: fix a crash in iova_magazine_free_pfns

On Thu, Jul 11, 2019 at 9:18 AM Qian Cai <cai@....pw> wrote:
>
> The commit b3aa14f02254 ("iommu: remove the mapping_error dma_map_ops
> method") incorrectly changed the checking from dma_ops_alloc_iova() in
> map_sg() causes a crash under memory pressure as dma_ops_alloc_iova()
> never return DMA_MAPPING_ERROR on failure but 0, so the error handling
> is all wrong.

This one seems to have fallen through the cracks.

Applied directly.

Maybe it's hiding in some fixes tree that I haven't gotten a pull
request for yet?

           Linus