linux-kernel - Re: [PATCH] allocate_flower_entry: should check for null deref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190721.114745.123875438153277101.davem@davemloft.net>
Date:   Sun, 21 Jul 2019 11:47:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     navid.emamdoost@...il.com
Cc:     kjlu@....edu, smccaman@....edu, secalert@...hat.com,
        emamd001@....edu, vishal@...lsio.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] allocate_flower_entry: should check for null deref

From: Navid Emamdoost <navid.emamdoost@...il.com>
Date: Sun, 21 Jul 2019 01:37:31 -0500

> allocate_flower_entry does not check for allocation success, but tries
> to deref the result. I only moved the spin_lock under null check, because
>  the caller is checking allocation's status at line 652.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>

Applied.