linux-kernel - Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 21 Jul 2019 21:03:35 +0200
From:   Pavel Machek <pavel@....cz>
To:     Pawel Laszczak <pawell@...ence.com>
Cc:     felipe.balbi@...ux.intel.com, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, rogerq@...com,
        linux-kernel@...r.kernel.org, jbergsagel@...com, nsekhar@...com,
        nm@...com, sureshp@...ence.com, jpawar@...ence.com,
        kurahul@...ence.com, aniljoy@...ence.com
Subject: Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

Hi!

> This patch introduce new Cadence USBSS DRD driver to linux kernel.
> 
> The Cadence USBSS DRD Controller is a highly configurable IP Core which
> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
> Host Only (XHCI)configurations.

I see you are using debugfs to select between DRD, peripheral-onlyh and XHCI... 

Is that good idea?

This is at least 3rd driver needing that capability, and debugfs does not
sound like a good match.

									Pavel