linux-kernel - Re: [PATCH v3 1/1] hwmon: (k8temp) update to use new hwmon registration API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16e03db49372a5f240b241f985f8685c@riseup.net>
Date:   Sun, 21 Jul 2019 13:37:31 -0700
From:   avoidr@...eup.net
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Rudolf Marek <r.marek@...embler.cz>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Robert Karszniewicz <avoidr@...email.cc>,
        linux-hwmon-owner@...r.kernel.org
Subject: Re: [PATCH v3 1/1] hwmon: (k8temp) update to use new hwmon
 registration API

On 2019-07-21 17:14, Guenter Roeck wrote:
> On Sun, Jul 21, 2019 at 02:00:51PM +0200, Robert Karszniewicz wrote:
>> Removes:
>> - hwmon_dev from k8temp_data struct, as that is now passed
>>   to callbacks, anyway.
>> - other k8temp_data struct fields, too.
>> - k8temp_update_device()
>>
>> Also reduces binary size:
>>    text    data     bss     dec     hex filename
>>    4139    1448       0    5587    15d3 drivers/hwmon/k8temp.ko.bak
>>    3103    1220       0    4323    10e3 drivers/hwmon/k8temp.ko
>>
>> Signed-off-by: Robert Karszniewicz <avoidr@...email.cc>
>> Signed-off-by: Robert Karszniewicz <avoidr@...eup.net>
> 
> Applied.

Thank you! It's been a joy!

>> ---
>> Changes from v2:
>> - if (data->swap_core_select)
>> -     core ^= 1;
>> + core ^= data->swap_core_select;
>>
>> However, that produces slightly more .text than v2, and is a tad too
>> "tricky", I personally find.
>>
> Interesting - for me it produces ~30 bytes less code (with gcc 7.4.0).

Strange. I just verified to make sure and I do get ~30 bytes /more/ code
(with gcc 9.1.0).