linux-kernel - Re: [PATCH] staging/wlan-ng: Fixing "line over 80 characters" warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 21 Jul 2019 12:03:40 +0200
From:   Hennie Muller <hm@...labs.co.za>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Tim Collier <osdevtc@...il.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/wlan-ng: Fixing "line over 80 characters"
 warnings.

On Sun, Jul 21, 2019 at 11:29:19AM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jul 21, 2019 at 11:13:26AM +0200, Hennie Muller wrote:
> > Reindent multiline function calls to be tab aligned, instead of open brace
> > aligned. This fixes multiple "WARNING: line over 80 characters" generated
> > by checkpatch.
> > 
> > Signed-off-by: Hennie Muller <hm@...labs.co.za>
> > ---
> >  drivers/staging/wlan-ng/cfg80211.c    |  55 ++---
> >  drivers/staging/wlan-ng/hfa384x_usb.c | 282 +++++++++++++-------------
> >  drivers/staging/wlan-ng/p80211conv.c  |  48 +++--
> >  drivers/staging/wlan-ng/p80211req.c   |   6 +-
> >  drivers/staging/wlan-ng/prism2fw.c    | 101 +++++----
> >  drivers/staging/wlan-ng/prism2mgmt.c  | 170 ++++++++--------
> >  drivers/staging/wlan-ng/prism2mib.c   |  14 +-
> >  drivers/staging/wlan-ng/prism2sta.c   | 282 +++++++++++++-------------
> >  drivers/staging/wlan-ng/prism2usb.c   |  13 +-
> >  9 files changed, 494 insertions(+), 477 deletions(-)
> > 
> > diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> > index eee1998c4b18..c69fb83267ef 100644
> > --- a/drivers/staging/wlan-ng/cfg80211.c
> > +++ b/drivers/staging/wlan-ng/cfg80211.c
> > @@ -130,8 +130,8 @@ static int prism2_change_virtual_intf(struct wiphy *wiphy,
> >  
> >  	/* Set Operation mode to the PORT TYPE RID */
> >  	result = prism2_domibset_uint32(wlandev,
> > -					DIDMIB_P2_STATIC_CNFPORTTYPE,
> > -					data);
> > +			DIDMIB_P2_STATIC_CNFPORTTYPE,
> > +			data);
> 
> This then violates another checkpatch warning, so you can't win :(
> 
> Just leave it as-is, it's fine, right?  Coding styles are there to make
> things easy to read and understand, and the code is fine like this.
Ok, perfect. I understand thanks. I'll move on to my next "first"
contribution then. :-)
> 
> So don't move arguments to the left of the '(' character on the line
> above please.
> 
> thanks,
> 
> greg k-h