lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 21 Jul 2019 13:26:07 +0800
From:   kbuild test robot <lkp@...el.com>
To:     "George G. Davis" <george_davis@...tor.com>
Cc:     kbuild-all@...org, Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        "George G. Davis" <george_davis@...tor.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: kmem: convert call_site addresses to user
 friendly symbols

Hi "George,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.2 next-20190719]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/George-G-Davis/tracing-kmem-convert-call_site-addresses-to-user-friendly-symbols/20190721-094536
config: arm-omap2plus_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:102:0,
                    from include/trace/events/kmem.h:321,
                    from mm/slab_common.c:27:
   include/trace/events/kmem.h: In function 'trace_raw_output_kmem_alloc':
>> include/trace/events/kmem.h:38:12: warning: format '%p' expects argument of type 'void *', but argument 3 has type 'long unsigned int' [-Wformat=]
     TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s",
               ^
   include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
     trace_seq_printf(s, print);     \
                         ^~~~~
>> include/trace/events/kmem.h:38:2: note: in expansion of macro 'TP_printk'
     TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s",
     ^~~~~~~~~
   In file included from include/trace/trace_events.h:394:0,
                    from include/trace/define_trace.h:102,
                    from include/trace/events/kmem.h:321,
                    from mm/slab_common.c:27:
   include/trace/events/kmem.h:38:24: note: format string is defined here
     TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s",
                          ~^
                          %ld
   In file included from include/trace/define_trace.h:102:0,
                    from include/trace/events/kmem.h:321,
                    from mm/slab_common.c:27:
   include/trace/events/kmem.h: In function 'trace_raw_output_kmem_alloc_node':
   include/trace/events/kmem.h:91:12: warning: format '%p' expects argument of type 'void *', but argument 3 has type 'long unsigned int' [-Wformat=]
     TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s node=%d",
               ^
   include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
     trace_seq_printf(s, print);     \
                         ^~~~~
   include/trace/events/kmem.h:91:2: note: in expansion of macro 'TP_printk'
     TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s node=%d",
     ^~~~~~~~~
   In file included from include/trace/trace_events.h:394:0,
                    from include/trace/define_trace.h:102,
                    from include/trace/events/kmem.h:321,
                    from mm/slab_common.c:27:
   include/trace/events/kmem.h:91:24: note: format string is defined here
     TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s node=%d",
                          ~^
                          %ld
   In file included from include/trace/define_trace.h:102:0,
                    from include/trace/events/kmem.h:321,
                    from mm/slab_common.c:27:
   include/trace/events/kmem.h: In function 'trace_raw_output_kmem_free':
   include/trace/events/kmem.h:134:12: warning: format '%p' expects argument of type 'void *', but argument 3 has type 'long unsigned int' [-Wformat=]
     TP_printk("call_site=%pS ptr=%p", __entry->call_site, __entry->ptr)
               ^
   include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
     trace_seq_printf(s, print);     \
                         ^~~~~
   include/trace/events/kmem.h:134:2: note: in expansion of macro 'TP_printk'
     TP_printk("call_site=%pS ptr=%p", __entry->call_site, __entry->ptr)
     ^~~~~~~~~
   In file included from include/trace/trace_events.h:394:0,
                    from include/trace/define_trace.h:102,
                    from include/trace/events/kmem.h:321,
                    from mm/slab_common.c:27:
   include/trace/events/kmem.h:134:24: note: format string is defined here
     TP_printk("call_site=%pS ptr=%p", __entry->call_site, __entry->ptr)
                          ~^
                          %ld

vim +38 include/trace/events/kmem.h

    13	
    14		TP_PROTO(unsigned long call_site,
    15			 const void *ptr,
    16			 size_t bytes_req,
    17			 size_t bytes_alloc,
    18			 gfp_t gfp_flags),
    19	
    20		TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags),
    21	
    22		TP_STRUCT__entry(
    23			__field(	unsigned long,	call_site	)
    24			__field(	const void *,	ptr		)
    25			__field(	size_t,		bytes_req	)
    26			__field(	size_t,		bytes_alloc	)
    27			__field(	gfp_t,		gfp_flags	)
    28		),
    29	
    30		TP_fast_assign(
    31			__entry->call_site	= call_site;
    32			__entry->ptr		= ptr;
    33			__entry->bytes_req	= bytes_req;
    34			__entry->bytes_alloc	= bytes_alloc;
    35			__entry->gfp_flags	= gfp_flags;
    36		),
    37	
  > 38		TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s",
    39			__entry->call_site,
    40			__entry->ptr,
    41			__entry->bytes_req,
    42			__entry->bytes_alloc,
    43			show_gfp_flags(__entry->gfp_flags))
    44	);
    45	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (36715 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ