linux-kernel - Re: [patch 23/38] mm/sparsemem: introduce struct mem_section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190722054637.GW30461@dhcp22.suse.cz>
Date:   Mon, 22 Jul 2019 07:46:37 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>, toshi.kani@....com,
        rppt@...ux.ibm.com, richardw.yang@...ux.intel.com,
        pasha.tatashin@...een.com, osalvador@...e.de, logang@...tatee.com,
        jmoyer@...hat.com, Jerome Glisse <jglisse@...hat.com>,
        Jason Gunthorpe <jgg@...lanox.com>, jane.chu@...cle.com,
        Christoph Hellwig <hch@....de>,
        David Hildenbrand <david@...hat.com>,
        Jonathan Corbet <corbet@....net>, Qian Cai <cai@....pw>,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        mm-commits@...r.kernel.org
Subject: Re: [patch 23/38] mm/sparsemem: introduce struct mem_section_usage

On Fri 19-07-19 09:42:18, Linus Torvalds wrote:
> On Thu, Jul 18, 2019 at 11:13 PM Michal Hocko <mhocko@...nel.org> wrote:
> >
> > Has this been properly reviewed after the last rebase and is this
> > actually ready for merging? I have seen some follow up fixes
> > http://lkml.kernel.org/r/20190715081549.32577-1-osalvador@suse.de
> > and do not see those patches being in the pipe line. Or have they been
> > merged?
> 
> It looks to me from the patches that Andrew updated them with
> 
>   https://lore.kernel.org/linux-mm/20190715081549.32577-2-osalvador@suse.de/
> 
> and
> 
>   https://lore.kernel.org/linux-mm/20190718120543.GA8500@linux/
> 
> so it looks good to me.
> 
> But that's just from reading the patches, I might have missed
> something and I don't see the history.

Thanks for double checking! It's good that follow up fixes didn't fall
through cracks. Anyway I have to say that I find merging shortly after a
non-trivial rebase as risky and rushed through. I am not really
convinced this is so urgent to warrant such a step.

I hoped to get to it eventually and give it a deeper review because this
is a non trivial stuff. I am sorry but I couldn't have done that yet
(busy with other stuff and being OOO for quite some time).
-- 
Michal Hocko
SUSE Labs