linux-kernel - Re: [PATCH] leds: ktd2692: Fix a typo in the name of a constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3d0d746-5f3f-77ae-428c-001e242c9a8d@gmail.com>
Date:   Mon, 22 Jul 2019 22:13:53 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>, pavel@....cz,
        dmurphy@...com
Cc:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] leds: ktd2692: Fix a typo in the name of a constant

Hi Christophe,

Thank you for the patch.

On 7/21/19 11:05 PM, Christophe JAILLET wrote:
> There is a typo in KTD2962_MM_MIN_CURR_THRESHOLD_SCALE. 6 and 9 are
> switched in 2962.
> 
> Define and use KTD2692_MM_MIN_CURR_THRESHOLD_SCALE instead.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/leds/leds-ktd2692.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/leds-ktd2692.c b/drivers/leds/leds-ktd2692.c
> index 45296aaca9da..44db748c570e 100644
> --- a/drivers/leds/leds-ktd2692.c
> +++ b/drivers/leds/leds-ktd2692.c
> @@ -22,7 +22,7 @@
>  /* Value related the movie mode */
>  #define KTD2692_MOVIE_MODE_CURRENT_LEVELS	16
>  #define KTD2692_MM_TO_FL_RATIO(x)		((x) / 3)
> -#define KTD2962_MM_MIN_CURR_THRESHOLD_SCALE	8
> +#define KTD2692_MM_MIN_CURR_THRESHOLD_SCALE	8
>  
>  /* Value related the flash mode */
>  #define KTD2692_FLASH_MODE_TIMEOUT_LEVELS	8
> @@ -253,7 +253,7 @@ static void ktd2692_setup(struct ktd2692_context *led)
>  	ktd2692_expresswire_reset(led);
>  	gpiod_direction_output(led->aux_gpio, KTD2692_LOW);
>  
> -	ktd2692_expresswire_write(led, (KTD2962_MM_MIN_CURR_THRESHOLD_SCALE - 1)
> +	ktd2692_expresswire_write(led, (KTD2692_MM_MIN_CURR_THRESHOLD_SCALE - 1)
>  				 | KTD2692_REG_MM_MIN_CURR_THRESHOLD_BASE);
>  	ktd2692_expresswire_write(led, KTD2692_FLASH_MODE_CURR_PERCENT(45)
>  				 | KTD2692_REG_FLASH_CURRENT_BASE);
> 

Applied.

-- 
Best regards,
Jacek Anaszewski