linux-kernel - Re: [PATCH] tracing: kmem: convert call_site addresses to user friendly symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190722212322.GA10300@mam-gdavis-lt>
Date:   Mon, 22 Jul 2019 17:23:22 -0400
From:   "George G. Davis" <george_davis@...tor.com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     Ingo Molnar <mingo@...hat.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: kmem: convert call_site addresses to user
 friendly symbols

Hello Steve,

On Mon, Jul 22, 2019 at 09:43:43AM -0400, Steven Rostedt wrote:
> 
> Looking at the kbuild report...
> 
> On Fri, 19 Jul 2019 22:22:40 -0400
> "George G. Davis" <george_davis@...tor.com> wrote:
> 
> > diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h
> > index eb57e3037deb..ae18e61fa1c0 100644
> > --- a/include/trace/events/kmem.h
> > +++ b/include/trace/events/kmem.h
> > @@ -35,7 +35,7 @@ DECLARE_EVENT_CLASS(kmem_alloc,
> >  		__entry->gfp_flags	= gfp_flags;
> >  	),
> >  
> > -	TP_printk("call_site=%lx ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s",
> > +	TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s",
> 
> Note, %lx expects an unsigned long, %pS expects a pointer.
> 
> >  		__entry->call_site,
> 
> You need to change the above to: (void *)__entry->call_site,

Oops, I should have paid more attention. Fixed.

Thanks!

> 
> -- Steve
> 
> >  		__entry->ptr,
> >  		__entry->bytes_req,

-- 
Regards,
George