linux-kernel - Re: [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190722213156.8829E21900@mail.kernel.org>
Date:   Mon, 22 Jul 2019 14:31:55 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Codrin.Ciubotariu@...rochip.com, Ludovic.Desroches@...rochip.com,
        Nicolas.Ferre@...rochip.com, alexandre.belloni@...tlin.com
Cc:     linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1

Quoting Nicolas.Ferre@...rochip.com (2019-07-03 08:05:24)
> On 25/06/2019 at 11:10, Codrin Ciubotariu wrote:
> > In clk_generated_determine_rate(), if the divisor is greater than
> > GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned.
> > If clk_generated_set_rate() will be called later with this wrong
> > rate, it will return -EINVAL, so the generated clock won't change
> > its value. Do no let the divisor be greater than GENERATED_MAX_DIV + 1.
> > 
> > Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor loop")
> > Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> > Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
> > Acked-by: Ludovic Desroches <ludovic.desroches@...rochip.com>
> > ---
> > 
> > - The email-server was converting my patches to base64, so I resend it
> >    using another server;
> > - Added acked-bys from Nicolas and Ludovic;
> 
> Stephen,
> 
> I don't see this patch in linux-next and we're already late in the 
> development cycle: aka ping...
> 

Sorry. I dropped this one. Will pick it up into fixes.