linux-kernel - Re: [PATCH v5 0/5] soc: qcom: Add SoC info driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190722232309.GS30636@minitux>
Date:   Mon, 22 Jul 2019 16:23:09 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Vaishali Thakkar <vaishali.thakkar@...aro.org>
Cc:     agross@...nel.org, david.brown@...aro.org,
        gregkh@...uxfoundation.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, rafael@...nel.org, vkoul@...nel.org
Subject: Re: [PATCH v5 0/5] soc: qcom: Add SoC info driver

On Thu 11 Jul 14:39 PDT 2019, Vaishali Thakkar wrote:

> This patchset adds SoC info driver which can provide information
> such as Chip ID, Chip family and serial number about Qualcomm SoCs
> to user space via sysfs. Furthermore, it allows userspace to get
> information about custom attributes and various image version
> information via debugfs.
> 
> The patchset cleanly applies on top of v5.2-rc7.

Hi Vaishali,

There's no context in the patches so they do not apply properly. Please
resubmit them with appropriate context.

Regards,
Bjorn

> 
> Changes since v1:
>         - Align ifdefs to left, remove unnecessary debugfs dir
>           creation check and fix function signatures in patch 3
>         - Fix comment for teh case when serial number is not
>           available in patch 1
> 
> Changes since v2:
>         - Reorder patches [patch five -> patch two]
> 
> Changes since v3:
>         - Add reviewed-bys from Greg
>         - Fix build warning when debugfs is disabled
>         - Remove extra checks for dir creations in patch 5
> 
> Changes since v4:
> 	- Added Reviewed-bys in multiple patches
> 	- Bunch of nitpick fixes in patch 3
> 	- Major refactoring for using core debugfs functions and
> 	  eliminating duplicate code in patch 4 and 5 [detailed info
> 	  can be found under --- in each patch]
> 
> Vaishali Thakkar (5):
>   base: soc: Add serial_number attribute to soc
>   base: soc: Export soc_device_register/unregister APIs
>   soc: qcom: Add socinfo driver
>   soc: qcom: socinfo: Expose custom attributes
>   soc: qcom: socinfo: Expose image information
> 
>  Documentation/ABI/testing/sysfs-devices-soc |   7 +
>  drivers/base/soc.c                          |   9 +
>  drivers/soc/qcom/Kconfig                    |   8 +
>  drivers/soc/qcom/Makefile                   |   1 +
>  drivers/soc/qcom/smem.c                     |   9 +
>  drivers/soc/qcom/socinfo.c                  | 468 ++++++++++++++++++++
>  include/linux/sys_soc.h                     |   1 +
>  7 files changed, 503 insertions(+)
>  create mode 100644 drivers/soc/qcom/socinfo.c
> 
> -- 
> 2.17.1
>