linux-kernel - Re: [PATCH v3 5/6] dt-bindings: interconnect: Add interconnect-opp-table property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190722233927.GA1353@bogus>
Date:   Mon, 22 Jul 2019 17:39:27 -0600
From:   Rob Herring <robh@...nel.org>
To:     Saravana Kannan <saravanak@...gle.com>
Cc:     Georgi Djakov <georgi.djakov@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Stephen Boyd <sboyd@...nel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        vincent.guittot@...aro.org, seansw@....qualcomm.com,
        daidavid1@...eaurora.org, Rajendra Nayak <rnayak@...eaurora.org>,
        sibis@...eaurora.org, bjorn.andersson@...aro.org,
        evgreen@...omium.org, kernel-team@...roid.com,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/6] dt-bindings: interconnect: Add
 interconnect-opp-table property

On Tue, Jul 02, 2019 at 06:10:19PM -0700, Saravana Kannan wrote:
> Add support for listing bandwidth OPP tables for each interconnect path
> listed using the interconnects property.
> 
> Signed-off-by: Saravana Kannan <saravanak@...gle.com>
> ---
>  .../devicetree/bindings/interconnect/interconnect.txt     | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/interconnect/interconnect.txt b/Documentation/devicetree/bindings/interconnect/interconnect.txt
> index 6f5d23a605b7..fc5b75b76a2c 100644
> --- a/Documentation/devicetree/bindings/interconnect/interconnect.txt
> +++ b/Documentation/devicetree/bindings/interconnect/interconnect.txt
> @@ -55,10 +55,18 @@ interconnect-names : List of interconnect path name strings sorted in the same
>  			 * dma-mem: Path from the device to the main memory of
>  			            the system
>  
> +interconnect-opp-table: List of phandles to OPP tables (bandwidth OPP tables)
> +			that specify the OPPs for the interconnect paths listed
> +			in the interconnects property. This property can only
> +			point to OPP tables that belong to the device and are
> +			listed in the device's operating-points-v2 property.
> +

IMO, there's no need for this property. Which OPP is which should be 
defined already as part of the device's binding. That's enough for the 
driver to know which OPP applies to the interconnect.

>  Example:
>  
>  	sdhci@...4000 {
> +		operating-points-v2 = <&sdhc_opp_table>, <&sdhc_mem_opp_table>;
>  		...
>  		interconnects = <&pnoc MASTER_SDCC_1 &bimc SLAVE_EBI_CH0>;
>  		interconnect-names = "sdhc-mem";
> +		interconnect-opp-table = <&sdhc_mem_opp_table>;
>  	};
> -- 
> 2.22.0.410.gd8fdbe21b5-goog
>