linux-kernel - Re: [PATCH] video: fbdev: nvidia: Remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Jul 2019 13:56:51 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     adaplas@...il.com, b.zolnierkie@...sung.com
Cc:     linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org,
        Sabyasachi Gupta <sabyasachi.linux@...il.com>
Subject: Re: [PATCH] video: fbdev: nvidia: Remove dead code

On Wed, Jul 10, 2019 at 11:41 PM Souptick Joarder <jrdr.linux@...il.com> wrote:
>
> This is dead code since 3.15. If there is no plan to use it
> further, this can be removed forever.

Any comment on this patch ?

>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> ---
>  drivers/video/fbdev/nvidia/nv_setup.c | 24 ------------------------
>  1 file changed, 24 deletions(-)
>
> diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c
> index b17acd2..2fa6866 100644
> --- a/drivers/video/fbdev/nvidia/nv_setup.c
> +++ b/drivers/video/fbdev/nvidia/nv_setup.c
> @@ -119,34 +119,10 @@ u8 NVReadMiscOut(struct nvidia_par *par)
>  {
>         return (VGA_RD08(par->PVIO, VGA_MIS_R));
>  }
> -#if 0
> -void NVEnablePalette(struct nvidia_par *par)
> -{
> -       volatile u8 tmp;
> -
> -       tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
> -       VGA_WR08(par->PCIO, VGA_ATT_IW, 0x00);
> -       par->paletteEnabled = 1;
> -}
> -void NVDisablePalette(struct nvidia_par *par)
> -{
> -       volatile u8 tmp;
> -
> -       tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
> -       VGA_WR08(par->PCIO, VGA_ATT_IW, 0x20);
> -       par->paletteEnabled = 0;
> -}
> -#endif  /*  0  */
>  void NVWriteDacMask(struct nvidia_par *par, u8 value)
>  {
>         VGA_WR08(par->PDIO, VGA_PEL_MSK, value);
>  }
> -#if 0
> -u8 NVReadDacMask(struct nvidia_par *par)
> -{
> -       return (VGA_RD08(par->PDIO, VGA_PEL_MSK));
> -}
> -#endif  /*  0  */
>  void NVWriteDacReadAddr(struct nvidia_par *par, u8 value)
>  {
>         VGA_WR08(par->PDIO, VGA_PEL_IR, value);
> --
> 1.9.1
>