linux-kernel - Re: [PATCH 1/2] [RESEND] dmaengine: omap-dma: make omap_dma_filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190722143533.GX12733@vkoul-mobl.Dlink>
Date:   Mon, 22 Jul 2019 20:05:33 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Peter Ujfalusi <peter.ujfalusi@...com>,
        Dan Williams <dan.j.williams@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        dmaengine@...r.kernel.org
Subject: Re: [PATCH 1/2] [RESEND] dmaengine: omap-dma: make
 omap_dma_filter_fn private

On 22-07-19, 16:22, Arnd Bergmann wrote:
> On Mon, Jul 22, 2019 at 4:13 PM Vinod Koul <vkoul@...nel.org> wrote:
> >
> > On 22-07-19, 10:16, Arnd Bergmann wrote:
> > > With the audio driver no longer referring to this function, it
> > > can be made private to the dmaengine driver itself, and the
> > > header file removed.
> > >
> > > Acked-by: Peter Ujfalusi <peter.ujfalusi@...com>
> > > Link: https://lore.kernel.org/lkml/20190307151646.1016966-1-arnd@arndb.de/
> >
> > This seems to point to older rev, my script updated it to latest one.
> 
> That was intentional, to see the replies to the last time it got
> posted. I'm not sure if that's the best way to do it, would you
> rather not have that included?

That's a valid point, but should we add both the links or just relevant
one, common sense says former, scripting tends to add so keep both...?

I am thinking of not changing the one submitted and let my
script append. Is that fine?

Thanks
-- 
~Vinod