linux-kernel - Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Fix missing break in switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Jul 2019 11:13:45 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Liu, Shaoyun" <Shaoyun.Liu@....com>,
        "Cox, Philip" <Philip.Cox@....com>,
        Oded Gabbay <oded.gabbay@...il.com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Fix missing break in
 switch statement



On 7/22/19 10:58 AM, Deucher, Alexander wrote:
> We need to add a /*fall through */ comment then.
> 

It might be better to remove the call to pr_debug() in KFD_MQD_TYPE_CP:

	case KFD_MQD_TYPE_CP:
       	case KFD_MQD_TYPE_COMPUTE:
		pr_debug("%s@%i\n", __func__, __LINE__);
		mqd->allocate_mqd = allocate_mqd;

Thanks
--
Gustavo


> Alex
> ________________________________
> From: Liu, Shaoyun <Shaoyun.Liu@....com>
> Sent: Monday, July 22, 2019 11:14 AM
> To: Gustavo A. R. Silva <gustavo@...eddedor.com>; Cox, Philip <Philip.Cox@....com>; Oded Gabbay <oded.gabbay@...il.com>; Deucher, Alexander <Alexander.Deucher@....com>; Koenig, Christian <Christian.Koenig@....com>; Zhou, David(ChunMing) <David1.Zhou@....com>; David Airlie <airlied@...ux.ie>; Daniel Vetter <daniel@...ll.ch>
> Cc: amd-gfx@...ts.freedesktop.org <amd-gfx@...ts.freedesktop.org>; dri-devel@...ts.freedesktop.org <dri-devel@...ts.freedesktop.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
> Subject: Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Fix missing break in switch statement
> 
> This one properly in purpose , The mqd init for CP and  COMPUTE will
> have the same  routine .
> 
> Regard
> 
> sshaoyun.liu
> 
> On 2019-07-21 6:59 p.m., Gustavo A. R. Silva wrote:
>> Add missing break statement in order to prevent the code from falling
>> through to case KFD_MQD_TYPE_COMPUTE.
>>
>> This bug was found thanks to the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Fixes: 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)")
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>> ---
>>   drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
>> index 4f8a6ffc5775..1d8b13ad46f9 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
>> @@ -430,6 +430,7 @@ struct mqd_manager *mqd_manager_init_v10(enum KFD_MQD_TYPE type,
>>        switch (type) {
>>        case KFD_MQD_TYPE_CP:
>>                pr_debug("%s@%i\n", __func__, __LINE__);
>> +             break;
>>        case KFD_MQD_TYPE_COMPUTE:
>>                pr_debug("%s@%i\n", __func__, __LINE__);
>>                mqd->allocate_mqd = allocate_mqd;
>