linux-kernel - Re: [PATCH] lib: zstd: Make ZSTD_compressBlock_greedy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201907221004.76B87B1A@keescook>
Date:   Mon, 22 Jul 2019 10:04:14 -0700
From:   Kees Cook <keescook@...omium.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     gustavo@...eddedor.com, terrelln@...com, clm@...com,
        yamada.masahiro@...ionext.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib: zstd: Make ZSTD_compressBlock_greedy_extDict static

On Wed, Jul 17, 2019 at 05:18:52PM +0800, YueHaibing wrote:
> Fix sparse warnings:
> 
> lib/zstd/compress.c:2252:6: warning:
>  symbol 'ZSTD_compressBlock_greedy_extDict' was not declared. Should it be static?
> lib/zstd/compress.c:2982:14: warning:
>  symbol 'ZSTD_createCStream_advanced' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  lib/zstd/compress.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/zstd/compress.c b/lib/zstd/compress.c
> index 5e0b67003e55..651d686c00b6 100644
> --- a/lib/zstd/compress.c
> +++ b/lib/zstd/compress.c
> @@ -2249,7 +2249,11 @@ void ZSTD_compressBlock_lazy_extDict_generic(ZSTD_CCtx *ctx, const void *src, si
>  	}
>  }
>  
> -void ZSTD_compressBlock_greedy_extDict(ZSTD_CCtx *ctx, const void *src, size_t srcSize) { ZSTD_compressBlock_lazy_extDict_generic(ctx, src, srcSize, 0, 0); }
> +static void ZSTD_compressBlock_greedy_extDict(ZSTD_CCtx *ctx, const void *src,
> +					      size_t srcSize)
> +{
> +	ZSTD_compressBlock_lazy_extDict_generic(ctx, src, srcSize, 0, 0);
> +}
>  
>  static void ZSTD_compressBlock_lazy_extDict(ZSTD_CCtx *ctx, const void *src, size_t srcSize)
>  {
> @@ -2979,7 +2983,7 @@ size_t ZSTD_CStreamWorkspaceBound(ZSTD_compressionParameters cParams)
>  	return ZSTD_CCtxWorkspaceBound(cParams) + ZSTD_ALIGN(sizeof(ZSTD_CStream)) + ZSTD_ALIGN(inBuffSize) + ZSTD_ALIGN(outBuffSize);
>  }
>  
> -ZSTD_CStream *ZSTD_createCStream_advanced(ZSTD_customMem customMem)
> +static ZSTD_CStream *ZSTD_createCStream_advanced(ZSTD_customMem customMem)
>  {
>  	ZSTD_CStream *zcs;
>  
> -- 
> 2.20.1
> 
> 

-- 
Kees Cook