linux-kernel - RE: [PATCH v2] arm64: dts: fsl: pico-pi: Add a device tree for the PICO-PI-IMX8M

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <042F8805D2046347BB8420BEAE397A40749E9BDA@WILL-MAIL002.REu.RohmEu.com>
Date:   Mon, 22 Jul 2019 17:40:43 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     Shawn Guo <shawnguo@...nel.org>,
        Andra Danciu <andradanciu1997@...il.com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "leoyang.li@....com" <leoyang.li@....com>,
        "Fabio Estevam" <festevam@...il.com>,
        "aisheng.dong@....com" <aisheng.dong@....com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "angus@...ea.ca" <angus@...ea.ca>,
        "vabhav.sharma@....com" <vabhav.sharma@....com>,
        "pankaj.bansal@....com" <pankaj.bansal@....com>,
        "bhaskar.upadhaya@....com" <bhaskar.upadhaya@....com>,
        "ping.bai@....com" <ping.bai@....com>,
        "Manivannan Sadhasivam" <manivannan.sadhasivam@...aro.org>,
        Richard Hu <richard.hu@...hnexion.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-imx@....com" <linux-imx@....com>,
        Daniel Baluta <daniel.baluta@....com>
Subject: RE: [PATCH v2] arm64: dts: fsl: pico-pi: Add a device tree for the
 PICO-PI-IMX8M

Sorry for top posting. I'm replying using mobile phone and outlook web app... 

gpio_intr is not needed. Irq must be given using the standard irq property. gpio_intr has been used in an old draft driver - I assume the dts originates from NXP bsp which used the old driver.

Br,
Matti Vaittinen

--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes.  Just then, he vanished ~~~


________________________________________
From: Shawn Guo [shawnguo@...nel.org]
Sent: Monday, July 22, 2019 5:03 AM
To: Andra Danciu
Cc: robh+dt@...nel.org; mark.rutland@....com; leoyang.li@....com; Fabio Estevam; aisheng.dong@....com; l.stach@...gutronix.de; angus@...ea.ca; vabhav.sharma@....com; pankaj.bansal@....com; bhaskar.upadhaya@....com; ping.bai@....com; Manivannan Sadhasivam; Richard Hu; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; Vaittinen, Matti; linux-imx@....com; Daniel Baluta
Subject: Re: [PATCH v2] arm64: dts: fsl: pico-pi: Add a device tree for the PICO-PI-IMX8M

On Thu, Jul 18, 2019 at 02:12:10PM +0300, Andra Danciu wrote:
...
> > > +     pmic: pmic@4b {
> > > +             reg = <0x4b>;
> > > +             compatible = "rohm,bd71837";
> > > +             /* PMIC BD71837 PMIC_nINT GPIO1_IO12 */
> > > +             pinctrl-0 = <&pinctrl_pmic>;
> > > +             gpio_intr = <&gpio1 3 GPIO_ACTIVE_LOW>;
> >
> > Where is the bindings for this property?
> Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt

I do not see property 'gpio_intr' in there.

Shawn