linux-kernel - Re: [alsa-devel][PATCH] Signed-off-by: lsh <410860423@...com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALAqxLUL-p6eF5tK3SnYa0RbCHLg92uQ-Z9T8U0QGnNbpnJG5g@mail.gmail.com>
Date:   Mon, 22 Jul 2019 10:59:28 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     lsh <linsheng_111@....com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>, 42304622@...com,
        lsh <410860423@...com>
Subject: Re: [alsa-devel][PATCH] Signed-off-by: lsh <410860423@...com>

On Fri, Jul 19, 2019 at 11:35 PM lsh <linsheng_111@....com> wrote:
>
> From: lsh <410860423@...com>
>
> Modification of leap seconds from 58 59 59 00 to 58 59 00 00

In the future, on other patches, you should provide a rational for
*why* you are submitting this change, not what the change does.

As for this patch, it would be a bad change, as this changes the
established behavior that the repeating 59th second w/ the TIME_OOP
flag set is the 60th/leap second and would break any apps that care to
actually watch for the leap second. Your change would cause
applications that do not care about leapseconds which have timers set
to the 00:00:00 UTC to fire a second early.

thanks
-john