| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190723233651.GD47047@google.com>
Date: Tue, 23 Jul 2019 18:36:51 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Kelsey Skunberg <skunberg.kelsey@...il.com>
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-kernel-mentees@...ts.linuxfoundation.org,
Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [Linux-kernel-mentees] [PATCH] PCI: Remove unused
EXPORT_SYMBOL()s from drivers/pci/bus.c
[+cc Greg]
On Wed, Jul 17, 2019 at 12:23:53PM -0600, Kelsey Skunberg wrote:
> pci_bus_get() and pci_bus_put() are not used by a loadable kernel module
> and do not need to be exported. Remove lines exporting pci_bus_get() and
> pci_bus_put().
>
> Functions were exported in commit fe830ef62ac6 ("PCI: Introduce
> pci_bus_{get|put}() to manage PCI bus reference count"). No found history
> of functions being used by a loadable kernel module.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey@...il.com>
Applied with Greg's ack to pci/hide for v5.4, thanks!
> ---
> drivers/pci/bus.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
> index 495059d923f7..8e40b3e6da77 100644
> --- a/drivers/pci/bus.c
> +++ b/drivers/pci/bus.c
> @@ -417,11 +417,9 @@ struct pci_bus *pci_bus_get(struct pci_bus *bus)
> get_device(&bus->dev);
> return bus;
> }
> -EXPORT_SYMBOL(pci_bus_get);
>
> void pci_bus_put(struct pci_bus *bus)
> {
> if (bus)
> put_device(&bus->dev);
> }
> -EXPORT_SYMBOL(pci_bus_put);
> --
> 2.20.1
>
> _______________________________________________
> Linux-kernel-mentees mailing list
> Linux-kernel-mentees@...ts.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Powered by blists - more mailing lists