linux-kernel - Re: [PATCH 1/2] ARM: dts: aspeed: tiogapass: Add VR devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69DFAF50-E181-4C7A-910A-C45E6E151F8E@fb.com>
Date:   Tue, 23 Jul 2019 00:33:40 +0000
From:   Vijay Khemka <vijaykhemka@...com>
To:     Andrew Jeffery <andrew@...id.au>, Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh+dt@...nel.org>,
        "Mark Rutland" <mark.rutland@....com>,
        Joel Stanley <joel@....id.au>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>
CC:     "openbmc @ lists . ozlabs . org" <openbmc@...ts.ozlabs.org>,
        Sai Dasari <sdasari@...com>
Subject: Re: [PATCH 1/2] ARM: dts: aspeed: tiogapass: Add VR devices



On 7/22/19, 5:12 PM, "Andrew Jeffery" <andrew@...id.au> wrote:

    Hi Vijay,
    
    A few nitpicks.
    
    On Tue, 23 Jul 2019, at 05:10, Vijay Khemka wrote:
    > Addes
    
    Typo: Adds
Ack
    
    > Voltage
    
    Unnecessary capitalisation.
Ack
    
    > regulators Infineon pxe1610 devices to Facebook
    > tiogapass platform.
    > 
    > Signed-off-by: Vijay Khemka <vijaykhemka@...com>
    > ---
    >  .../dts/aspeed-bmc-facebook-tiogapass.dts     | 36 +++++++++++++++++++
    >  1 file changed, 36 insertions(+)
    > 
    > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts 
    > b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    > index c4521eda787c..b7783833a58c 100644
    > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    > @@ -144,6 +144,42 @@
    >  &i2c5 {
    >  	status = "okay";
    >  	// CPU Voltage regulators
    > +	vr@48 {
    
    The recommended generic name is 'regulator', so e.g. regulator@48
Ack: Submitted v2 for this patch.
    
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x48>;
    > +	};
    > +	vr@4a {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x4a>;
    > +	};
    > +	vr@50 {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x50>;
    > +	};
    > +	vr@52 {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x52>;
    > +	};
    > +	vr@58 {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x58>;
    > +	};
    > +	vr@5a {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x5a>;
    > +	};
    > +	vr@68 {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x68>;
    > +	};
    > +	vr@70 {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x70>;
    > +	};
    > +	vr@72 {
    > +		compatible = "infineon,pxe1610";
    > +		reg = <0x72>;
    > +	};
    >  };
    >  
    >  &i2c6 {
    > -- 
    > 2.17.1
    > 
    >