linux-kernel - Re: [PATCH] lightnvm: introduce pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <45E0A0E6-52B0-4BF9-B816-33F6ECDD0E5F@javigon.com>
Date:   Tue, 23 Jul 2019 07:47:15 +0200
From:   Javier González <javier@...igon.com>
To:     minwoo.im@...sung.com
Cc:     Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Minwoo Im <minwoo.im.dev@...il.com>,
        Matias Bjørling <mb@...htnvm.io>,
        Klaus Birkelund Jensen <birkelund@...il.com>
Subject: Re: [PATCH] lightnvm: introduce pr_fmt for the previx nvm

> On 22 Jul 2019, at 06.31, Minwoo Im <minwoo.im@...sung.com> wrote:
> 
>>> @@ -1111,27 +1112,27 @@ static int nvm_init(struct nvm_dev *dev)
>>>  	int ret = -EINVAL;
>>> 
>>>  	if (dev->ops->identity(dev)) {
>>> -		pr_err("nvm: device could not be identified\n");
>>> +		pr_err("device could not be identified\n");
>>>  		goto err;
>>>  	}
>>> 
>>> -	pr_debug("nvm: ver:%u.%u nvm_vendor:%x\n",
>>> +	pr_debug("ver:%u.%u nvm_vendor:%x\n",
>>>  				geo->major_ver_id, geo->minor_ver_id,
>>>  				geo->vmnt);
>> The above last 2 lines can be squashed and pr_debug call can be made in
>> 2 lines since you have removed the "nvm:" which shortens the first line.
> 
> Yeah Okay.  Will prepare V2 with this and also s/previx/prefix in the
> title.
> 
> Thanks for the review.
> 
> Minwoo Im

Besides Chaitanya’s comments, looks good. You can add my review on V2.

Reviewed-by: Javier González <javier@...igon.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)