linux-kernel - Re: [PATCH] regulator: stm32-booster: Remove .min_uV and .list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d36c7925-1374-80e0-60e2-b08377be1f5f@st.com>
Date:   Tue, 23 Jul 2019 10:07:30 +0200
From:   Fabrice Gasnier <fabrice.gasnier@...com>
To:     Axel Lin <axel.lin@...ics.com>, Mark Brown <broonie@...nel.org>
CC:     Liam Girdwood <lgirdwood@...il.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: stm32-booster: Remove .min_uV and
 .list_voltage for fixed regulator

On 7/23/19 3:41 AM, Axel Lin wrote:
> Setting .n_voltages = 1 and .fixed_uV is enough for fixed regulator,
> remove the redundant .min_uV and .list_voltage settings.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Hi Axel,

Acked-by: Fabrice Gasnier <fabrice.gasnier@...com>

Thanks,
Fabrice
> ---
>  drivers/regulator/stm32-booster.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/regulator/stm32-booster.c b/drivers/regulator/stm32-booster.c
> index 2a897666c650..03f162ffd144 100644
> --- a/drivers/regulator/stm32-booster.c
> +++ b/drivers/regulator/stm32-booster.c
> @@ -20,7 +20,6 @@
>  #define STM32MP1_SYSCFG_EN_BOOSTER_MASK	BIT(8)
>  
>  static const struct regulator_ops stm32h7_booster_ops = {
> -	.list_voltage	= regulator_list_voltage_linear,
>  	.enable		= regulator_enable_regmap,
>  	.disable	= regulator_disable_regmap,
>  	.is_enabled	= regulator_is_enabled_regmap,
> @@ -31,7 +30,6 @@ static const struct regulator_desc stm32h7_booster_desc = {
>  	.supply_name = "vdda",
>  	.n_voltages = 1,
>  	.type = REGULATOR_VOLTAGE,
> -	.min_uV = 3300000,
>  	.fixed_uV = 3300000,
>  	.ramp_delay = 66000, /* up to 50us to stabilize */
>  	.ops = &stm32h7_booster_ops,
> @@ -53,7 +51,6 @@ static int stm32mp1_booster_disable(struct regulator_dev *rdev)
>  }
>  
>  static const struct regulator_ops stm32mp1_booster_ops = {
> -	.list_voltage	= regulator_list_voltage_linear,
>  	.enable		= stm32mp1_booster_enable,
>  	.disable	= stm32mp1_booster_disable,
>  	.is_enabled	= regulator_is_enabled_regmap,
> @@ -64,7 +61,6 @@ static const struct regulator_desc stm32mp1_booster_desc = {
>  	.supply_name = "vdda",
>  	.n_voltages = 1,
>  	.type = REGULATOR_VOLTAGE,
> -	.min_uV = 3300000,
>  	.fixed_uV = 3300000,
>  	.ramp_delay = 66000,
>  	.ops = &stm32mp1_booster_ops,
>