[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20190723090752.GB787@ravnborg.org>
Date: Tue, 23 Jul 2019 11:07:52 +0200
From: Sam Ravnborg <sam@...nborg.org>
To: Andrzej Pietrasiewicz <andrzej.p@...labora.com>
Cc: dri-devel@...ts.freedesktop.org,
Neil Armstrong <narmstrong@...libre.com>,
Maxime Ripard <maxime.ripard@...tlin.com>,
Douglas Anderson <dianders@...omium.org>,
Thierry Reding <thierry.reding@...il.com>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
kernel@...labora.com, linux-samsung-soc@...r.kernel.org,
linux-rockchip@...ts.infradead.org,
Vincent Abriou <vincent.abriou@...com>,
Krzysztof Kozlowski <krzk@...nel.org>,
Jonathan Hunter <jonathanh@...dia.com>,
David Airlie <airlied@...ux.ie>, Chen-Yu Tsai <wens@...e.org>,
Kukjin Kim <kgene@...nel.org>,
NXP Linux Team <linux-imx@....com>,
Dave Airlie <airlied@...hat.com>,
intel-gfx@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
linux-tegra@...r.kernel.org, Jonas Karlman <jonas@...boo.se>,
linux-arm-msm@...r.kernel.org,
Alexios Zavras <alexios.zavras@...el.com>,
Mamta Shukla <mamtashukla555@...il.com>,
linux-mediatek@...ts.infradead.org, Jyri Sarha <jsarha@...com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Thomas Gleixner <tglx@...utronix.de>,
Sean Paul <sean@...rly.run>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
linux-arm-kernel@...ts.infradead.org,
amd-gfx@...ts.freedesktop.org,
Tomi Valkeinen <tomi.valkeinen@...com>,
Thomas Zimmermann <tzimmermann@...e.de>,
Seung-Woo Kim <sw0312.kim@...sung.com>,
linux-kernel@...r.kernel.org, Todor Tomov <todor.tomov@...aro.org>,
Kyungmin Park <kyungmin.park@...sung.com>,
Huang Rui <ray.huang@....com>,
Alex Deucher <alexander.deucher@....com>,
Shawn Guo <shawnguo@...nel.org>,
Christian König <christian.koenig@....com>,
Gerd Hoffmann <kraxel@...hat.com>
Subject: Re: [PATCH v4 16/23] drm/mgag200: Provide ddc symlink in connector
sysfs directory
Hi Andrzej.
On Thu, Jul 11, 2019 at 01:26:43PM +0200, Andrzej Pietrasiewicz wrote:
> Use the ddc pointer provided by the generic connector.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@...labora.com>
> ---
> drivers/gpu/drm/mgag200/mgag200_mode.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
> index a25054015e8c..8fb9444b2142 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_mode.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
> @@ -1703,6 +1703,11 @@ static struct drm_connector *mga_vga_init(struct drm_device *dev)
> return NULL;
>
> connector = &mga_connector->base;
> + mga_connector->i2c = mgag200_i2c_create(dev);
> + if (!mga_connector->i2c)
> + DRM_ERROR("failed to add ddc bus\n");
> +
> + connector->ddc = &mga_connector->i2c->adapter;
>
> drm_connector_init(dev, connector,
> &mga_vga_connector_funcs, DRM_MODE_CONNECTOR_VGA);
Like on other patch, assigning connector->ddc before
drm_connector_init() looks wrong.
Sam
Powered by blists - more mailing lists