linux-kernel - RE: [PATCH net-next 0/3] net: stmmac: Convert to phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR12MB32694541534ED0ABA3C55BE6D3C70@BYAPR12MB3269.namprd12.prod.outlook.com>
Date:   Tue, 23 Jul 2019 09:36:42 +0000
From:   Jose Abreu <Jose.Abreu@...opsys.com>
To:     Ondřej Jirman <megi@....cz>,
        Jose Abreu <Jose.Abreu@...opsys.com>
CC:     Andrew Lunn <andrew@...n.ch>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        "David S . Miller" <davem@...emloft.net>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Russell King <linux@...linux.org.uk>,
        Florian Fainelli <f.fainelli@...il.com>,
        "Heiner Kallweit" <hkallweit1@...il.com>
Subject: RE: [PATCH net-next 0/3] net: stmmac: Convert to phylink

From: Ondřej Jirman <megi@....cz>
Date: Jul/22/2019, 15:39:55 (UTC+00:00)

> On Mon, Jul 22, 2019 at 02:26:45PM +0000, Jose Abreu wrote:
> > From: Andrew Lunn <andrew@...n.ch>
> > Date: Jul/22/2019, 15:19:43 (UTC+00:00)
> > 
> > > On Mon, Jul 22, 2019 at 01:58:20PM +0000, Jose Abreu wrote:
> > > > From: Andrew Lunn <andrew@...n.ch>
> > > > Date: Jul/22/2019, 14:40:23 (UTC+00:00)
> > > > 
> > > > > Does this mean that all stmmac variants support 1G? There are none
> > > > > which just support Fast Ethernet?
> > > > 
> > > > This glue logic drivers sometimes reflect a custom IP that's Synopsys 
> > > > based but modified by customer, so I can't know before-hand what's the 
> > > > supported max speed. There are some old versions that don't support 1G 
> > > > but I expect that PHY driver limits this ...
> > > 
> > > If a Fast PHY is used, then yes, it would be limited. But sometimes a
> > > 1G PHY is used because they are cheaper than a Fast PHY.
> > >  
> > > > > I'm also not sure the change fits the problem. Why did it not
> > > > > negotiate 100FULL rather than 10Half? You are only moving the 1G
> > > > > speeds around, so 100 speeds should of been advertised and selected.
> > > > 
> > > > Hmm, now that I'm looking at it closer I agree with you. Maybe link 
> > > > partner or PHY doesn't support 100M ?
> > > 
> > > In the working case, ethtool shows the link partner supports 10, 100,
> > > and 1G. So something odd is going on here.
> > > 
> > > You fix does seems reasonable, and it has been reported to fix the
> > > issue, but it would be good to understand what is going on here.
> > 
> > Agreed!
> > 
> > Ondrej, can you please share dmesg log and ethtool output with the fixed 
> > patch ?
> 
> See the attachment, or this link:

So, I've removed all 1G link modes from stmmac and run it on an ARM 
based board. My link status resolves to 100M/Full using Generic PHY so 
maybe something is wrong with the PHY driver that Ondrej is using 
("RTL8211E Gigabit Ethernet") ?

---
Thanks,
Jose Miguel Abreu