linux-kernel - Re: [PATCH] hwmon: Remove ads1015 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Jul 2019 17:07:22 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Rob Herring <robh@...nel.org>
Cc:     Jonathan Cameron <jic23@...nel.org>, devicetree@...r.kernel.org,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, Dirk Eibach <eibach@...ys.de>
Subject: Re: [PATCH] hwmon: Remove ads1015 driver

On Mon, Jul 22, 2019 at 04:39:44PM -0600, Rob Herring wrote:
> On Mon, Jul 01, 2019 at 11:12:38AM -0700, Guenter Roeck wrote:
> > A driver for ADS1015 with more functionality is available in the iio
> > subsystem.
> > 
> > Remove the hwmon driver as duplicate. If the chip is used for hardware
> > monitoring, the iio->hwmon bridge should be used.
> > 
> > Cc: Dirk Eibach <eibach@...ys.de>
> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> > ---
> > Current plan is to queue this removal for v5.4 (not v5.3) in the hwmon
> > tree.
> > 
> >  .../devicetree/bindings/hwmon/ads1015.txt          |  73 -----
> >  .../devicetree/bindings/iio/adc/ads1015.txt        |  73 +++++
> 
> I assume no change or I should review it again?
> 
It is identical.

> Acked-by: Rob Herring <robh@...nel.org>
> 
Thanks,
Guenter

> >  Documentation/hwmon/ads1015.rst                    |  90 ------
> >  Documentation/hwmon/index.rst                      |   1 -
> >  MAINTAINERS                                        |   8 -
> >  drivers/hwmon/Kconfig                              |  10 -
> >  drivers/hwmon/Makefile                             |   1 -
> >  drivers/hwmon/ads1015.c                            | 324 ---------------------
> >  drivers/iio/adc/Kconfig                            |   2 +-
> >  9 files changed, 74 insertions(+), 508 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/hwmon/ads1015.txt
> >  create mode 100644 Documentation/devicetree/bindings/iio/adc/ads1015.txt
> >  delete mode 100644 Documentation/hwmon/ads1015.rst
> >  delete mode 100644 drivers/hwmon/ads1015.c